docs: add PR title and DCO rules to CONTRIBUTING.md#321
Merged
beeme1mr merged 3 commits intoopen-feature:mainfrom Feb 14, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 86.88% 86.88%
=======================================
Files 13 13
Lines 1372 1372
=======================================
Hits 1192 1192
Misses 156 156
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dab3d5f to
93e091e
Compare
Signed-off-by: Eli Treuherz <et@arenko.group>
Signed-off-by: Eli Treuherz <et@arenko.group>
93e091e to
e5387f7
Compare
beeme1mr
approved these changes
Feb 13, 2025
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Eli Treuherz <1574403+treuherz@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the commit convention to the CONTRIBUTING docs. This caught me out on #320, hopefully this helps the next person!